Adis, On Wed, Jan 22, 2020 at 04:57:10PM +0100, Adis Nezirovic wrote: > Hello, > > Here it is, I've introduced a bug in last patch (since it is recent I've put > "MINOR", even if it might have bigger impact in prod.
Strangely, while I was certain I had build-tested the original one, apparently I failed as it didn't build for two errors, which I fixed in a subsequent patch. I'm seeing that your patches still seem to rely on this bug (data_op < 0) which normally cannot compile so I find this surprising. I still merged the first one of these two because I think it's OK, however, could you please add a bit of commit message to the second one ? As a rule of thumb, the commit message should be used to "sell" me your patch and to sell it to whoever would be hesitating in backporting it or not. Thus I think that here the benefits and/or impacts are not obvious from this one-liner : > Subject: [PATCH 2/2] MINOR: cli: Report location of error or any extra data > for "show table" Thanks! Willy
