Ilya, Am 22.01.20 um 22:41 schrieb Илья Шипицин: > let us move it to Github Actions. > as far as I tried no extra step are required for enabling, just proper file > in > > .github/workflows
Yes, that's my understanding of GitHub actions as well. However I dislike having three types of CI (Travis, Cirrus and GitHub Actions). Can Travis be replaced with GitHub Actions for our use case? I guess Cirrus can't, because FreeBSD? To the patch: > From 372c547a94ff02fa04ca052a87863161d3e85b37 Mon Sep 17 00:00:00 2001 > From: Ilya Shipitsin <[email protected]> > Date: Thu, 23 Jan 2020 02:33:38 +0500 > Subject: [PATCH] BUILD: CI: move cygwin builds to Github Actions > > builds on travis-ci fail because of > https://travis-ci.community/t/cygwin-issue-cygheap-base-mismatch-detected/5359 > unfortunately, documentation does not help. > > so, let us move builds to Github Actions. > > also, remove deprecated "sudo" directive from .travis.yml Could you please create separate patches for several unrelated changes? If there's an "also" in the commit message then that's an indication that the patch should be split. Single-line patches are perfectly acceptable. I send series containing multiple single-line patches to the list on a regular basis (as distinct emails even, because I use git-send-email). > + steps: > + - uses: actions/checkout@v1 > + - name: install prerequisites > + run: choco install bash make libssl-devel cygwin-devel gcc-core > libgcc1 binutils lua-devel libpcre-devel zlib-devel --source cygwin > + - name: fake step Give a proper name to that step. "Show pwd" is fine. > + run: C:\\tools\\cygwin\\bin\\bash -lc 'pwd' > + - name: build > + run: C:\\tools\\cygwin\\bin\\bash -lc 'cd $OLDPWD && make > TARGET=cygwin USE_ZLIB=1 USE_PCRE=1 USE_PCRE_JIT=1 USE_LUA=1 USE_OPENSSL=1 > USE_THREAD=1 && ./haproxy -vv' 1. Does GitHub Actions support variables for the build flags, similar to Travis? That would make things more readable. 2. Split the ./haproxy -vv into a separate step, if that's possible. Best regards Tim Düsterhus
