I've adjusted commit message. ср, 26 февр. 2020 г. в 12:40, Илья Шипицин <[email protected]>:
> it's pretty much like to gcc. > I've no idea why does FreeBSD decided to check its version (and nobody > knows). > > I'll update commit message > > ср, 26 февр. 2020 г. в 05:37, Tim Düsterhus <[email protected]>: > >> Ilya, >> >> Am 25.02.20 um 21:13 schrieb Илья Шипицин: >> > it turned out that FreeBSD image is slightly different from packages. >> > since we cannot change image, let us just suppress that warning. >> >> I'd like to point out this paragraph from the CONTRIBUTING document: >> >> > As a rule of thumb, your patch MUST NEVER be made only of a subject >> line, >> > it *must* contain a description. Even one or two lines, or indicating >> > whether a backport is desired or not. It turns out that single-line >> commits >> > are so rare in the Git world that they require special manual (hence >> > painful) handling when they are backported, and at least for this >> reason >> > it's important to keep this in mind. >> >> When reading your patch it was unclear to me which kind of version check >> needs to be ignored (and why). At the very least I would have expected a >> copy the actual error message from CI (that will be fixed after applying >> the patch) in the commit message. I'll copy it here for posterity. >> >> > Updating FreeBSD repository catalogue... >> > Fetching meta.conf: . done >> > Fetching packagesite.txz: .......... done >> > Processing entries: >> > Newer FreeBSD version for package p5-Bio-GFF3: >> > To ignore this error set IGNORE_OSVERSION=yes >> > - package: 1300081 >> > - running kernel: 1300078 >> > Ignore the mismatch and continue? [Y/n]: pkg: repository FreeBSD >> contains packages for wrong OS version: FreeBSD:13:amd64 >> > Processing entries... done >> > Unable to update repository FreeBSD >> > Error updating repositories! >> >> I'm not a FreeBSD guy, but my understanding after a short session with >> the search engine of my choice indicated that apparently the Cirrus CI >> VM is running an outdated kernel or possibly an outdated FreeBSD jail. >> I'm not sure whether that is correct or not. In any case an explanation >> why suddenly this error message popped up and why it's safe to ignore >> that specific error is safe would have been helpful in the commit >> message as well. >> >> Best regards >> Tim Düsterhus >> >
From 188581fda9a7110360f5bbbc7b56f9cda03ddd6c Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin <[email protected]> Date: Wed, 26 Feb 2020 19:29:36 +0500 Subject: [PATCH] BUILD: cirrus-ci: suppress OS version check when installing packages since we run "snapshot" images of FreeBSD, it is possible that kernel ABI version might change from time to time. It might differ from prebuilt packages (installed via "pkg"). We do not test kernel modules, so for us is safe to ignore ABI mismatch. --- .cirrus.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index 1a07c80c7..86b404782 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -5,6 +5,8 @@ FreeBSD_task: image_family: freebsd-12-1-snap image_family: freebsd-11-3-snap only_if: $CIRRUS_BRANCH =~ 'master|next' + env: + IGNORE_OSVERSION: yes # supress package installation error on FreeBSD-13 install_script: - pkg update -f && pkg upgrade -y && pkg install -y openssl git gmake lua53 socat script: -- 2.24.1
