Ilya,

Am 23.04.20 um 11:20 schrieb Илья Шипицин:
> src/mux_h2.c:5939:3: warning: Value stored to 'count' is never read
>                 count = 0;

without checking these in detail:

I have run scan-build before and got reports about dead stores as well.
In some places I would argue that these dead stores are intentional for
symmetry across different branches. Removing those dead stores breaks
the symmetry and might lead to bugs further down the road if the branch
is modified in a way that the dead store would no longer be dead.

One example of this is src/http_ana.c:3808. I would say that the dead
store should remain in there.

In short: This patch should carefully be checked and probably not all
changes should be applied.

Best regards
Tim Düsterhus

Reply via email to