On Mon, Jun 08, 2020 at 10:00:42AM +0500, ???? ??????? wrote:
> ??, 8 ???. 2020 ?. ? 03:58, Tim Düsterhus <[email protected]>:
>
> > Willy,
> >
> > Am 05.06.20 um 21:09 schrieb Willy Tarreau:
> > > I'm just asking here that the regular contributors have a glance at the
> > > branch named "20200605-rework-include-final" and honestly say how they
> > > feel about adopting this (even if they don't care, that's fine). Such
> > > work may only be done very late in the LTS cycle, and always has an
> > > impact on backports later, so I'd rather not do that again for the next
> > > few years!
> >
> > I don't care. My editor of choice allows me to easily jump to the
> > declaration of whatever I want to look up. So I don't really think in
> > terms of files anyway.
> >
>
> indeed, VS Code picks header from whatever place.
> when header location is important ? just curious
Mostly in two situations:
- when you have to add new code and you figure that un expected dependencies
force you to include other ones which break the build and you spend one
hour trying to address this instead of a few minutes. Last painful example
which convinced me it was about time to do this was when I had to duplicate
some inline functions from freq_ctr.h to memory.h!
- when you add new code and have no idea where to place it, and you decide
do imitate what's already in place but the example you pick was a known
bad old one, and you end up adding more dirt by accident.
But that's great if it means this has little visible impact.
Thanks,
Willy
