Willy, William Am 29.05.20 um 14:35 schrieb Tim Duesterhus: > These two patches re-enable some build warnings in the Makefile. The first one > only enables those that did not trigger for me at all. > > The second one re-enables -Wimplicit-fallthrough. I could not adjust all > places, because I was not sure whether they work as intended. > > I've Cc't Willy (stream_interface, pattern) and William (cli), because they > where the ones that wrote the switch statements. I've also added Ilya, because > applying the second patch will most likely fail the Travis build. > > I'd say that the one in 'pattern' is a bug and that the other two just need a > /* fall through */ comment. > > See the build log below for what I'm seeing within a debian:sid Docker > container: > > [...] > > Tim Düsterhus (2): > BUILD: Remove nowarn for warnings that do not trigger > BUILD: Re-enable -Wimplicit-fallthrough > > Makefile | 3 --- > src/acl.c | 2 ++ > src/checks.c | 4 ++-- > src/hlua.c | 2 ++ > src/peers.c | 8 ++++---- > 5 files changed, 10 insertions(+), 9 deletions(-) >
With the new -dev9 I'd like to move this thread up the INBOX again, in case you want to resolve this before the release. Best regards Tim Düsterhus
