Hi List,
Willy,
Ilya,

I noticed that the reg-tests were unable find the issue reported by
William here:
https://www.mail-archive.com/[email protected]/msg37637.html

This is because VTest never performs a "soft" shutdown of HAProxy,
instead it uses SIGINT -> SIGTERM -> SIGKILL. Thus the deinit() will
never trigger.

Fixing this will require a change to VTest:
https://github.com/vtest/VTest/blob/b9e9e03fdeebd494783ae1dd8e6008f5c1e3a4bc/src/vtc_haproxy.c#L786
needs to be SIGUSR1 (and the switch below adjusted).

Making the change in my local repository and running the tests that
don't need any additional USE_XXX falgs causes 3 tests to fail with 2 of
them triggering an assertion within VTest.

It would have caught the bug reported by William, though.

Concluding: It probably makes sense to adjust VTest to use SIGUSR1
instead of SIGINT, the latter is handled like SIGTERM in HAProxy anyway,
so there is no need for this distinction. I did not yet look into the
details of the failing tests, though.

Best regards
Tim Düsterhus

Reply via email to