Hi,
On Mon, Jul 06, 2020 at 03:01:26AM +0000, [email protected] wrote:
> Hi, Willy,
>
> Thank you for your quick reply!
>
> > But I mean, that's probably OK and I won't argue on this. I'd be
> > interested in others' opinions and/or suggestions on this, but
> > it's not critical.
>
> Thank you for your comment.
> If these keywords are inappropriate for users,
> please feel free to tell me anytime.
> I'm not particular about these keywords :-)
>
> > Yes please, in the same commit so that any eventual backport that may
> > happen isn't lost!
>
> I understand.
> I've included a fix for doc/configuration.txt in the patch.
> If you have any problems fixing the documentation, please let us know.
>
> > Please just add "tcp:" as a subsystem tag.
> > I think you can tag it MINOR as the impact is extremely low
>
> I changed the Subject to:
> --------
> MINOR: tcp: Support TCP keepalive parameters customization
> --------
>
> Thank you for your cooperation.
So I had a look at it, everything looks good but I'm thinking that
the "tcpka-*" keywords which act on both sides will only result in
trouble, because if they are in a defaults section for example, there
will be some confusion regarding whether they are used by default or
the other side-specific keyword is used. The typical case is this one:
defaults
srvka-cnt 10
backend foo
tcpka-cnt 5
It's not obvious to me which one will have precedence here. Given that
even in the doc you strongly suggested to use only clika-* and srvka-*,
I'd rather kill the dual-sided tcpka-* before they start to be used.
Would that be OK for you ?
Other than that I'm OK with merging the patch as-is and it's clean.
Thank you!
Willy
