Hi Dmitry
On Sat, Jul 18, 2020 at 12:29:10PM +0300, Dmitry Sivachenko wrote:
>
> 1) new warnings:
>
> src/log.c:1692:10: warning: logical not is only applied to the left hand side
> of this comparison [-Wlogical-not-parentheses]
> while (HA_SPIN_TRYLOCK(LOGSRV_LOCK, &logsrv->lock) != 0) {
> ^ ~~
> include/common/hathreads.h:1026:33: note: expanded from macro
> 'HA_SPIN_TRYLOCK'
> #define HA_SPIN_TRYLOCK(lbl, l) !pl_try_s(l)
> ^
> src/log.c:1692:10: note: add parentheses after the '!' to evaluate the
> comparison first
> include/common/hathreads.h:1026:33: note: expanded from macro
> 'HA_SPIN_TRYLOCK'
> #define HA_SPIN_TRYLOCK(lbl, l) !pl_try_s(l)
> ^
> src/log.c:1692:10: note: add parentheses around left hand side expression to
> silence this warning
> while (HA_SPIN_TRYLOCK(LOGSRV_LOCK, &logsrv->lock) != 0) {
> ^
> ( )
> include/common/hathreads.h:1026:33: note: expanded from macro
> 'HA_SPIN_TRYLOCK'
> #define HA_SPIN_TRYLOCK(lbl, l) !pl_try_s(l)
> ^
>
This looks like a missing backport because the issue was encountered and
fixed in master.
https://github.com/haproxy/haproxy/commit/db57a142c31016ff3e0dd533cb2b4de14445781e
--
Jérôme
