Hi Tim,

On Sat, Sep 12, 2020 at 05:32:03PM +0200, Tim Duesterhus wrote:
> This fixes at least one instance where the wrong type was given to sizeof.
> clang-analyzer complained that in src/cfgparse.c line 3614 
> (newsrv->curr_idle_thr):
> 
> > Result of 'calloc' is converted to a pointer of type 'unsigned int', which 
> > is
> > incompatible with sizeof operand type 'int'
> 
(...)

Thanks for doing this, I really appreciate it as I too hate having
a named type in calloc, as it doesn't survive code changes over time.

I'd rather have one patch to fix the known bug and the rest as a
cleanup patch however, so that we can backport the fix wherever
needed without risking to break something subtle by accident. Just
let me know if that's OK for you, otherwise I'll take care of slicing
your patch next week.

Thanks!
Willy

Reply via email to