Hello,

I've found that "socat" was not properly detected under Fedora docker image.

(maybe we should introduce "set -e" as well)

Cheers,
Ilya Shipitcin
From 0063a45f37c18f305ea3e1155c87e071ccce7600 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin <chipits...@gmail.com>
Date: Sat, 26 Sep 2020 11:54:27 +0500
Subject: [PATCH] REGTESTS: use "command" instead of "which" for better POSIX
 compatibility

for example, "which" is not installed by default in Fedora docker image.
---
 scripts/run-regtests.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/run-regtests.sh b/scripts/run-regtests.sh
index af25a6075..7bcc394cf 100755
--- a/scripts/run-regtests.sh
+++ b/scripts/run-regtests.sh
@@ -191,8 +191,8 @@ _findtests() {
     done
 
     for requiredbin in $require_binaries; do
-      which $requiredbin >/dev/null 2>&1
-      if [ "$?" -eq "1" ]; then
+      if ! command -v $requiredbin >/dev/null 2>&1
+      then
         echo "  Skip $i because '"$requiredbin"' is not installed"
         skiptest=1
       fi
-- 
2.26.2

Reply via email to