Hello Tim, On Thu, Oct 22, 2020 at 09:15:04PM +0200, Tim Duesterhus wrote: > William, > Rémi, > > I'm super happy to see that the support for if-none-match made it into 2.3. I > already was considering poking under some of the recent -devX announcements, > but thought it already was too late for it and thus did not. > > Consider taking the following patches: > > - CLEANUP: This one probably can be argued about. I thought that the previous > implementation did not really fit HAProxy's code style, it felt > very unnatural to me. But of course that's personal preferences.
In my opinion the code is readable enough, I'll skip your patch because it's really personal preferences. > - BUG/MINOR: This was something Christopher noted during review of my earlier > series. The adjustment of the status code is probably failing > roughly never, but I guess it's better to be safe there. > I think the impact is reasonable here, I'll take this one. Thanks! -- William Lallemand
