Maciej,

Am 18.11.20 um 18:48 schrieb Maciej Zdeb:
> Tim thanks for the hint!

You're welcome.

> Aleksandar I’ll do my best, however I’m still learning HAProxy internals
> and refreshing my C skills after very long break. ;) First, I’ll try to
> deliver something simple like „-m beg” and after review from the team we’ll
> see.

As a community contributor that regularly sends patches for stuff and
that also sometimes reviews patches from other contributors:

I must say that you made a very good start with your first patch.
Christopher made some adjustments, but it's clear that you read the
CONTRIBUTING guide, because all the formal requirements were met. From
my experience many already fail at that stage.

Just add reg-tests for your next development and I'd say it's perfect
:-) I'm looking forward to see your patches, even if I don't need them
personally.

> If someone is in hurry with this issue and wants to implement it asap, then
> just let me know.
> 
Best regards
Tim Düsterhus

Reply via email to