Hi Tim, There's a crash report on github: https://github.com/haproxy/haproxy/issues/909#issuecomment-732241492 with a reproducer and also stack trace from Willy. That list init is necessary because release_http_action() is trying to iterate over and free its elements: http://git.haproxy.org/?p=haproxy.git;a=blob;f=src/http_act.c;h=13a5c370da861c78f21037186808ee16325ab45a;hb=HEAD#l52
Now I had more time to look at the code and maybe a cleaner solution is to add an additional check to release_http_action() instead of initializing the list (patch attached). pon., 23 lis 2020 o 20:38 Tim Düsterhus <[email protected]> napisał(a): > Maciej, > > Am 23.11.20 um 17:15 schrieb Maciej Zdeb: > > By accident I removed initialization of log-format list during > > implementation of -m flag for http-request/response del-header. :( > > > > This patch restores the init. > > > > Again from my "I'm am not an export" viewpoint: > > I'm not sure whether this is necessary. As you don't take a log-format > string you shouldn't need that. The previous existence of that line > probably was a copy and paste mistake. > > Did you encounter any issues with the removal of that line or did you > just review your diff? If you actually had issues it would be helpful if > you would put a reproducer into the commit message. > > Best regards > Tim Düsterhus >
0001-BUG-MINOR-http_act-Fix-segv-on-release_http_action.patch
Description: Binary data
