Hi I have a small patch which adds a new log-format variable %HPR for logging relative path. I hope it is clean and useful! :)
Kind regards, czw., 26 lis 2020 o 19:08 Willy Tarreau <[email protected]> napisał(a): > Hi Maciej, > > On Thu, Nov 26, 2020 at 12:39:19PM +0100, Maciej Zdeb wrote: > > Hi, > > > > Since 30ee1efe676e8264af16bab833c621d60a72a4d7 "MEDIUM: h2: use the > > normalized URI encoding for absolute form requests" we're using absolute > > URI when possible. As stated in the commit message this also changed the > > way it is reported in logs, especially for H2. > > > > Docs describes %HP as "HTTP request URI without query string (path)" and > > the word "path" suggests that %HP behaves exactly the same as "path" > sample > > fetch (it surprised me after HAProxy update that it's not true). > Shouldn't > > we delete the "(path)" from that description? Even better would be to > > change it to "rel_path/abs_path" like it is in rfc or "relative/absolute > > URI" but it is too long. :) If I'm the only one that got confused then it > > may stay. But... > > > > Do you think that it might be useful to implement another var, let's say > > %HRU described as "HTTP request relative URI"? :) Usually in my logs I'm > > not interested in absolute uri and relative is sufficient. > > Few people play with absolute URIs in practice, that's why such issues > started to pop up very late. Your example above is just yet another proof > of this. So you're probalbly not the only one, but the few others might > have silently fixed the meaning in their mind while you've fixed it in the > doc, which is better! > > Applied now, thank you! > Willy >
0001-MINOR-log-Logging-relative-URI-path-with-HPR.patch
Description: Binary data
