Ilya,

Am 20.01.21 um 14:26 schrieb Илья Шипицин:
> Tim, what if we will introduce a bit more flexibility for VTest... For
> example, some github variable which (if defined) will mean "checkout this".
> Thus we will be able to override either master or specific branch/commit/tag

I don't think introducing additional complexity by that variable is
better than adding + reverting a patch that hardcodes a known good commit.

I fact I just went ahead and attached a patch.

Best regards
Tim Düsterhus
From ef80933eca0c8cf83e119cd9b3e96a5dcfd776e6 Mon Sep 17 00:00:00 2001
From: Tim Duesterhus <[email protected]>
Date: Wed, 20 Jan 2021 19:13:29 +0100
Subject: [PATCH] CI: Pin VTest to a known good commit
To: [email protected]
Cc: [email protected],
    [email protected]

As of January, 11th the macOS builds fail due to regression introduced in
VTest. This patch pins VTest to the newest good commit.

This patch should be reverted once VTest's 'master' is stable again.

see vtest/VTest#26
---
 .github/workflows/vtest.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/vtest.yml b/.github/workflows/vtest.yml
index 6d42db8ff..f5f35a6e1 100644
--- a/.github/workflows/vtest.yml
+++ b/.github/workflows/vtest.yml
@@ -60,7 +60,7 @@ jobs:
         brew install lua
     - name: Install VTest
       run: |
-        curl -fsSL https://github.com/vtest/VTest/archive/master.tar.gz -o VTest.tar.gz
+        curl -fsSL https://github.com/vtest/VTest/archive/02a9bc16d78e70d1d415b40d5349b9f3e56df05b.tar.gz -o VTest.tar.gz
         mkdir VTest
         tar xvf VTest.tar.gz -C VTest --strip-components=1
         make -C VTest -j$(nproc) FLAGS="-O2 -s -Wall"
-- 
2.29.0

Reply via email to