On Wed, Jan 20, 2021 at 4:33 PM William Dauchy <wdau...@gmail.com> wrote: > On Wed, Jan 20, 2021 at 4:08 PM Christopher Faulet <cfau...@haproxy.com> > wrote: > > Sorry for the delay. I reviewed your patches and that seems good for me. In > > fact, I was first a bit annoyed by the first one, because it adds 3 new > > fields > > just to change the unit (MB vs bytes). But the unit appears in the metric > > name > > so I guess it is ok this way. We must just be careful to not add too many > > specific fields. And, at the end, it is a great cleanup. > > I was also puzzled but could not find a better way; I think we did > this workaround in the past but that does not solve the issue in the > long term. I also wondered whether we could deprecate the MB one but I > already know the answer I believe ;)
Any thoughts about this Willy? -- William
