Willy, Am 28.01.21 um 17:27 schrieb Willy Tarreau: > On Thu, Jan 28, 2021 at 09:19:03PM +0500, ???? ??????? wrote: >> something went wrong >> >> https://github.com/haproxy/haproxy/runs/1781046618?check_suite_focus=true#step:4:40 > > Maybe the coverity build scripts use the single quote as an internal
It appears as if Coverity does not take quoting into account at all, instead simply splitting the arguments at whitespace. This is dumb of course. > delimiter. I must say I really hate this development model consisting > in committing just to see if that fixes, then fix again, not only it's > ugly, but it wastes everyone's time. Sorry about this. I generally attempt to not send any untested patches, instead testing with my GitHub fork of HAProxy. I think I usually succeed with this ... Unfortunately in this case I was unable to test the patch due to the lack of access to Coverity, so I sent a "best effort" patch that I assumed would work after Ilya reported that apparently the BUG_ON() was not working. > Stupid question, doesn't coverity pre-set some defines that could be > checked in the code instead of constantly having to define extra > "DEBUG_xxx" stuff to shut it up ? Maybe there's even something for > the unreachable case by the way. Ilya will need to answer this. Best regards Tim Düsterhus
