Hi Thierry, On Wed, Mar 03, 2021 at 07:57:42AM +0100, Thierry Fournier wrote: > Hi list, > > Listing metrics for supervision, I see an undesirable space in a > metric name 54 "Unstoppable Jobs". > > 44.CompressBpsRateLim.1:CLP:u32:0 > 47.Tasks.1:MGP:u32:455 > 48.Run_queue.1:MGP:u32:1 > 49.Idle_pct.1:MaP:u32:92 > 50.node.1:COS:str:ozon3 > 52.Stopping.1:MGP:u32:0 > 53.Jobs.1:MGP:u32:81 > -> 54.Unstoppable Jobs.1:MGP:u32:0
Ah that's certainly not welcome here and definitely a mistake :-( > This space is introduced two year ago. If anyone uses this variable > I suggest a rename with "_" in place of space. I would really agree by principle, considering that the longer we wait, the worse it will be. However I don't know if anyone has already hard- coded any names in monitoring tools. I sincerely doubt anyone purposely collects this field, but I want to be sure we don't break anything for users. Changing it for just an underscore would ease the transition as a regex could remain trivial here for example. And we've done a few similar things in the past with the config. Maybe we could do that for 2.4 right now to leave it a bit of exposure. I don't think it would be reasonable to change this in a stable release (especially LTS ones). But if there are compelling reasons for doing it, maybe that could be considered for 2.3 as well. Does anyone have any opinion on this, and particularly a request such as "please don't do this, you'll break my tools and I don't have the sources to fix them" ? Thanks, Willy
