Le 15/04/2021 à 21:45, Tim Duesterhus a écrit :
Christopher,
again: Thank you for the very helpful review. In this series you can find v2 of
my URI normalization patches. I hope I did not forget to incorporate any of
your feedback.
Some general notes:
- I completely cleaned up the commit history to group similar patches (e.g. the
two patches for dotdot) and to avoid later commits completely refactoring
earlier commits (e.g. the error handling).
- As suggested I am now returning the error code and taking a `struct ist *dst`.
- The values of `enum uri_normalizer_err` are cleaned up.
- I cleaned up the error handling in `http_action_normalize_uri`.
- I am now using `istdiff()`.
- Dynamic allocation is no more.
- I fixed some parts of the code style (`struct ist* foo` -> `struct ist *foo`).
- I const'ified as much as possible.
Thanks Tim,
The series looks good to me. Except if Willy has any comments, I'll merge it
soon.
--
Christopher Faulet
