On Wed, Apr 21, 2021 at 10:03:16AM +0200, William Lallemand wrote: > Hello, > > On Wed, Apr 21, 2021 at 08:04:08AM +0200, Willy Tarreau wrote: > > [...] > > > > So after changing my mind, I would go with the following approach: > > > > - building with USE_SLZ=1 => always use the embedded one > > - building with USE_ZLIB=1 => always build using the user-provided zlib > > > > We'd enable USE_SLZ by default and it would be disabled when ZLIB is used > > (or when SLZ is forced off). This way we could have fast and memory-less > > compression available by default without the hassle of cloning an unknown > > repository. > > > > That looks good to me, however I think it's better to disable SLZ > manually when building with zlib so we can emit an error when both > options are disabled, this way people are encouraged to migrate and will > think twice before setting USE_ZLIB. The disadvantage is that it would > break existing compilation line, but it's for a new major release so > it's fine in my opinion.
I get your point but I find it cumbersome. Also, not everyone understands the "USE_FOO=" syntax to disable something. But that's something that can at least be debatted till the last minute, as it will have the lowest impact, so we can freely adapt to the most popular opinion on the subject. Willy
