I've created "proof of concept" OT support for CI https://github.com/chipitsine/haproxy/runs/2535689580
Tim, are you ok with that approach ? If yes, I will polish things a bit. currently "building OT and satellites" takes 2min 11sec. seem, I will add similar caching level as for SSL variants (i.e. checking version in "opt" and skip build if version is there). also, I caught an error on clang: https://github.com/haproxy/haproxy/issues/1242 I'm not very happy with unconditionally adding OT flags https://github.com/chipitsine/haproxy/commit/dcf1812b17bd2907939eaa8d3310378d419d90c5#diff-b525f86b1f4925509959f857496dff18a9c4ed34fcc7f49357c5a6d00fb64d17R91 Tim, do you know how to add it using ${{ contains(matrix.FLAGS, 'USE_OT=1') }} condition ? чт, 8 апр. 2021 г. в 14:44, Илья Шипицин <[email protected]>: > > > чт, 8 апр. 2021 г. в 14:25, Willy Tarreau <[email protected]>: > >> On Wed, Apr 07, 2021 at 05:26:24PM +0500, ???? ??????? wrote: >> > we run "all features anebled" gcc and clang builds, for example >> > BUG/MINOR: tools: fix parsing "us" unit for timers · >> > haproxy/haproxy@a683805 (github.com) >> > < >> https://github.com/haproxy/haproxy/runs/2275440914?check_suite_focus=true >> > >> > >> > < >> https://github.com/haproxy/haproxy/runs/2275440914?check_suite_focus=true >> > >> > if >> > additional libraries are easy to install (building will increase total >> time >> > a lot), I'd add opentracing to those "all features" builds >> >> I managed to build it myself so it's reasonably accessible, however we'd >> possibly need to cache the builds, or we'll really start to spend a lot >> of time building dependencies. >> > > That is what I meant. if build is cheap - ok. > if packages are available - ok. > > other options would be either caching dependencies (github ci supports > caches) or provisioning custom docker images for our builds > > >> >> Willy >> >
