Hi!

I hope I added all the active developers that touch the reg-tests to the 'CC'
list :-)

This series updates the regtests to make use of VTest's 'feature cmd' syntax
to skip tests that are not supported in the current environment.

In the long run this will should result in much cleaner tests, because they
don't need to be parsed by run-regtests.sh to extract these marker comments. It
also allows to easily add test specific requirements without needing to invent
an entirely new syntax. An example might be the recently added tests that are
not supported on BoringSSL. These should be able to get a condition like:

    feature cmd "$HAPROXY_PROGRAM -vv |grep -vq BoringSSL"

and then they won't run for BoringSSL (the example is untested).

After this series is applied the output of 'make reg-tests' will change. Tests
that are excluded using 'feature cmd' will still be listed as "Add test" in
the test gathering section. However the final line will show that a few tests
have been skipped:

    0 tests failed, 4 tests skipped, 105 tests passed

I don't think this is going to be an issue. But if it is, please complain!

If all of you are happy with the series then it might be merged. Just remember
to use 'feature cmd' after it is applied :-)

Best regards

Tim Düsterhus (4):
  REGTESTS: Replace REQUIRE_VERSION=2.5 with 'haproxy -cc'
  REGTESTS: Replace REQUIRE_OPTIONS with 'haproxy -cc' for 2.5+ tests
  REGTESTS: Replace REQUIRE_BINARIES with 'command -v'
  REGTESTS: Remove support for REQUIRE_BINARIES

 reg-tests/http-messaging/http_abortonclose.vtc |  2 +-
 reg-tests/mcli/mcli_start_progs.vtc            |  2 +-
 reg-tests/ssl/add_ssl_crt-list.vtc             |  2 +-
 reg-tests/ssl/new_del_ssl_cafile.vtc           |  6 +++---
 reg-tests/ssl/new_del_ssl_crlfile.vtc          |  6 +++---
 reg-tests/ssl/set_ssl_cafile.vtc               |  6 +++---
 reg-tests/ssl/set_ssl_cert.vtc                 |  2 +-
 reg-tests/ssl/set_ssl_cert_bundle.vtc          |  2 +-
 reg-tests/ssl/set_ssl_cert_noext.vtc           |  2 +-
 reg-tests/ssl/set_ssl_crlfile.vtc              |  6 +++---
 reg-tests/ssl/set_ssl_server_cert.vtc          |  2 +-
 reg-tests/ssl/show_ssl_ocspresponse.vtc        |  6 +++---
 reg-tests/startup/check_condition.vtc          |  1 -
 scripts/run-regtests.sh                        | 12 ------------
 14 files changed, 22 insertions(+), 35 deletions(-)

-- 
2.32.0


Reply via email to