Hi,

After version 2.4-dev7, we lost some statistics about agent checks,

When we added below code to /src/stats.c, we start to get result of the
agent checks in statistics. But we are not sure about our code.
If it is a bug will you fix it soon ?


after "case ST_F_CHECK_HEALTH:" lines

                        case ST_F_AGENT_STATUS:
        if ((sv->agent.state & (CHK_ST_ENABLED|CHK_ST_PAUSED)) ==
CHK_ST_ENABLED) {                                        const char
*fld_chksts;                                        fld_chksts =
chunk_newstr(out);
chunk_strcat(out, "* "); // for check in progress
                  chunk_strcat(out,
get_check_status_info(sv->agent.status));
          if (!(sv->agent.state & CHK_ST_INPROGRESS))
                              fld_chksts += 2; // skip "* "

metric = mkf_str(FN_OUTPUT, get_check_status_info(sv->agent.status));
                              }                                break;
                      case ST_F_AGENT_CODE:
    if ((sv->agent.state & (CHK_ST_ENABLED|CHK_ST_PAUSED)) ==
CHK_ST_ENABLED &&
sv->agent.status >= HCHK_STATUS_L57DATA)
         metric = mkf_u32(FN_OUTPUT, sv->agent.code);
              break;                        case ST_F_AGENT_DURATION:
                              if ((sv->agent.state &
(CHK_ST_ENABLED|CHK_ST_PAUSED)) == CHK_ST_ENABLED &&
                     sv->agent.status >= HCHK_STATUS_CHECKED)
                              metric = mkf_u64(FN_DURATION,
sv->agent.duration);                                break;
           case ST_F_AGENT_DESC:                                if
((sv->agent.state & (CHK_ST_ENABLED|CHK_ST_PAUSED)) == CHK_ST_ENABLED)
                                       metric = mkf_str(FN_OUTPUT,
get_check_status_description(sv->agent.status));
         break;                        case ST_F_LAST_AGT:
                   if ((sv->agent.state &
(CHK_ST_ENABLED|CHK_ST_PAUSED)) == CHK_ST_ENABLED)
                   metric = mkf_str(FN_OUTPUT, sv->agent.desc);
                        break;                        case
ST_F_AGENT_RISE:                                if ((sv->check.state &
(CHK_ST_ENABLED|CHK_ST_PAUSED)) == CHK_ST_ENABLED)
                   metric = mkf_u32(FO_CONFIG|FS_SERVICE,
ref->agent.rise);                                break;
        case ST_F_AGENT_FALL:                                if
((sv->check.state & (CHK_ST_ENABLED|CHK_ST_PAUSED)) == CHK_ST_ENABLED)
                                       metric =
mkf_u32(FO_CONFIG|FS_SERVICE, ref->agent.fall);
        break;                        case ST_F_AGENT_HEALTH:
                      if ((sv->check.state &
(CHK_ST_ENABLED|CHK_ST_PAUSED)) == CHK_ST_ENABLED)
                   me




Thanks,

Yusuf

Reply via email to