Miroslav,

On 9/10/21 12:31 PM, Miroslav Zagorac wrote:
I am sending 4 patches that revert to the opentracing filter function,
with the possibility of using haproxy variables to transfer the
opentracing context excluded.

Patch 2 looks odd to me. Is the issue that .ptr is equal to NULL and *that* is causing issues? Then I recommend the following instead:

if (!isttest(v))
  v = ist("");

this is much cleaner, because it does not attempt to cram so much logic into that single huge line.

In any case if the issue is a NULL then you must test for that NULL instead of testing the length.

Best regards
Tim Düsterhus

Reply via email to