This fixes the use of the various *cmp functions to use != 0 or == 0.
---
src/cfgparse.c | 2 +-
src/cli.c | 4 ++--
src/server.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/cfgparse.c b/src/cfgparse.c
index f013928f6..892170284 100644
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -1536,7 +1536,7 @@ static void check_section_position(char *section_name,
const char *file, int linenum,
int *non_global_parsed)
{
- if (!strcmp(section_name, "global")) {
+ if (strcmp(section_name, "global") == 0) {
if (*non_global_parsed == 1)
_ha_diag_warning("parsing [%s:%d] : global section
detected after a non-global one, the prevalence of their statements is
unspecified\n", file, linenum);
}
diff --git a/src/cli.c b/src/cli.c
index a3ee4c442..6a46f138c 100644
--- a/src/cli.c
+++ b/src/cli.c
@@ -1714,11 +1714,11 @@ static int cli_parse_expert_experimental_mode(char
**args, char *payload, struct
if (!cli_has_level(appctx, ACCESS_LVL_ADMIN))
return 1;
- if (!strcmp(args[0], "expert-mode")) {
+ if (strcmp(args[0], "expert-mode") == 0) {
level = ACCESS_EXPERT;
level_str = "expert-mode";
}
- else if (!strcmp(args[0], "experimental-mode")) {
+ else if (strcmp(args[0], "experimental-mode") == 0) {
level = ACCESS_EXPERIMENTAL;
level_str = "experimental-mode";
}
diff --git a/src/server.c b/src/server.c
index b8908cefa..15c4d0536 100644
--- a/src/server.c
+++ b/src/server.c
@@ -4681,7 +4681,7 @@ static int cli_parse_add_server(char **args, char
*payload, struct appctx *appct
while (1) {
/* check for duplicate server */
- if (!strcmp(srv->id, next->id)) {
+ if (strcmp(srv->id, next->id) == 0) {
ha_alert("Already exists a server with the same
name in backend.\n");
goto out;
}
--
2.33.0
