❦ 22 October 2021 21:08 +02, Willy Tarreau:
>> ? 19 October 2021 09:22 +02, Vincent Bernat:
>>
>> > This could be backported to 2.4. Older versions do not display CFLAGS.
>>
>> Note that if you find this too ugly, I have no problem to maintain this
>> as an OOT patch.
>
> I don't find it ugly. I think it's not the most elegant part of the
> makefile, but a makefile (and ours in particular) is generally not a
> collection of elegant stuff.
>
> I'm just thinking, we have a SILENT_DEFINE macro that should already
> address this. Could you please try to pass your -f... there ? If it
> works it would just be a matter of improving the SILENT_DEFINE
> description to indicate that it works as well for compiler options
> that we don't want to see on the output.
I don't use it directly, it's pushed by Debian build system with some
other flags. I could puts all of them (-g -O2
-ffile-prefix-map=/home/bernat/code/exoscale/haproxy=.
-fstack-protector-strong -Wformat -Werror=format-security) in
SILENT_DEFINE, but if at somepoint, some of them are more invasive, it
would may not be a good idea to hide them out of your view.
Maybe just sit on the patch and see if another distro see a need for it.
I'll keep it as a Debian patch for now and I'll complain in a few years
if I am tired of it.
--
Don't stop at one bug.
- The Elements of Programming Style (Kernighan & Plauger)
