Hi Tim, On Thu, Oct 28, 2021 at 05:33:57PM +0200, Tim Düsterhus, WoltLab GmbH wrote: > Willy, > > please find another halog series attached. > > 1. Some small changes to the new -qry/-query flag. > 2. A new -hdr flag, resolving my own GitHub issue.
OK, some points below. > From 50d5f579bc35fcffbf06a2fa2dbc8a4fd6944135 Mon Sep 17 00:00:00 2001 > From: Tim Duesterhus <duester...@woltlab.com> > Date: Thu, 28 Oct 2021 16:36:03 +0200 > Subject: [PATCH 2/5] MINOR: halog: Rename -qry to -query > To: haproxy@formilux.org > Cc: w...@1wt.eu > > With the query flag moved into the correct help section, there is enough space > for two additional characters. :-) I like how options are sometimes named just because of tiny details like this! Another possible option is sometimes "qs" for "query string" but I seem to remember it's already taken. Just one thing (but do not worry, I'll rearrange it later), I initially took great care of limiting the output to 80 columns for having suffered a few times from it, and I think it broke when time ranges were added. > From 2e09f62a989dfe3ef2a0965c8f42681db9af937e Mon Sep 17 00:00:00 2001 > From: Tim Duesterhus <duester...@woltlab.com> > Date: Thu, 28 Oct 2021 17:24:02 +0200 > Subject: [PATCH 5/5] MINOR: halog: Add support for extracting captures using > -hdr > To: haproxy@formilux.org > Cc: w...@1wt.eu > > This resolves GitHub issue #1146. On this one, please provide a description. It's fine to mention issues or any external info, but commit messages will outlive any external site, and they must contain a description of what is done. It seems to me that you're extracting the fields from the capture, and also that you're doing a special case of the quotes. I'm not sure how they appear on the output though. We don't need many details, but just a few lines about this would help. I'm taking the first 4 already. For this one it's fine for me if you just propose me a few lines that I can paste into your patch before applying it, or just resend it if you prefer. Thanks! Willy
