In theory, we can drop QUICTLS/gcc build, leaving only clang.
let us spend some time on fixing and decide

чт, 18 нояб. 2021 г. в 18:48, Amaury Denoyelle <[email protected]>:

> On Thu, Nov 18, 2021 at 06:27:56PM +0500, Ilya Shipitsin wrote:
> > script/build-ssl.sh is used mostly in CI, let us introduce QUIC
> > OpenSSL fork support
> > ---
> >  scripts/build-ssl.sh | 23 +++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> > diff --git a/scripts/build-ssl.sh b/scripts/build-ssl.sh
> > index e1d89a0eb..d143cec55 100755
> > --- a/scripts/build-ssl.sh
> > +++ b/scripts/build-ssl.sh
> > @@ -86,6 +86,17 @@ download_boringssl () {
> >      fi
> >  }
> >
> > +download_quictls () {
> > +    if [ ! -d "download-cache/quictls" ]; then
> > +        git clone --depth=1 https://github.com/quictls/openssl
> download-cache/quictls
> > +    else
> > +       (
> > +        cd download-cache/quictls
> > +        git pull
> > +       )
> > +    fi
> > +}
> > +
> >  if [ ! -z ${LIBRESSL_VERSION+x} ]; then
> >       download_libressl
> >       build_libressl
> > @@ -121,3 +132,15 @@ if [ ! -z ${BORINGSSL+x} ]; then
> >       )
> >  fi
> >
> > +if [ ! -z ${QUICTLS+x} ]; then
> > +        (
> > +
> > +        download_quictls
> > +        cd download-cache/quictls
> > +
> > +        ./config shared --prefix="${HOME}/opt"
> --openssldir="${HOME}/opt" --libdir=lib -DPURIFY
> > +        make -j$(nproc) build_sw
> > +        make install_sw
> > +
> > +        )
> > +fi
> > --
> > 2.29.2.windows.2
> >
>
> Thank you for your patches. However, we should probably fix the GCC
> error reproduced on your repository before merging it. This will prevent
> to have a red test indicator indefinitely.
>
> --
> Amaury Denoyelle
>

Reply via email to