On 12/27/2021 01:16 PM, Miroslav Zagorac wrote:
Hello all,
to avoid misunderstandings (like say github issue #1493) when compiling
HAproxy source with the OpenTracing filter enabled, a warning has been
added if the OT_USE_VARS variable is used.
If appropriate, please apply this commit.
Best regards.
sorry, i forgot the patch. :(
--
Miroslav Zagorac
>From 93e02c8b6d1eb14cfb16e0ba1feddf3b10a77f06 Mon Sep 17 00:00:00 2001
From: Miroslav Zagorac <mzago...@haproxy.com>
Date: Mon, 27 Dec 2021 12:44:07 +0100
Subject: [PATCH] BUILD: opentracing: display warning in case of using
OT_USE_VARS at compile time
Please do not set the OT_USE_VARS configuration variable, as the source
will probably not be able to compile! For now, this variable can only
be used for experimental purposes, and is not intended for wider use.
For further clarification, please see commit 4cb2c83f4.
---
addons/ot/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/addons/ot/Makefile b/addons/ot/Makefile
index 0cc8c6aad..c7b0f8db9 100644
--- a/addons/ot/Makefile
+++ b/addons/ot/Makefile
@@ -65,6 +65,8 @@ OPTIONS_OBJS += \
addons/ot/src/util.o
ifneq ($(OT_USE_VARS),)
+$(warning Please do not set the OT_USE_VARS configuration variable, as the source will probably not be able to compile! For now, this variable can only be used for experimental purposes, and is not intended for wider use.)
+
OT_DEFINE = -DUSE_OT_VARS
OPTIONS_OBJS += \
addons/ot/src/vars.o
--
2.30.2
