Hello, this is cleanup patch that removes default (non needed) step condition. behavior is not changed.
thanks, Ilya
From edbcc5312efa468f028ea8d97cbe1393aafdfcd7 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin <[email protected]> Date: Fri, 7 Jan 2022 20:09:35 +0500 Subject: [PATCH] CI: github actions: clean default step conditions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit step condition "if: ${{ !failure() }}" was added in 2ef4c7c84363f5a9b80a2093df1370514319db28 during my experiments. As Tim Düsterhus mentioned, that condition is default and may be omitted. --- .github/workflows/vtest.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/vtest.yml b/.github/workflows/vtest.yml index 121c37d4e..421384b46 100644 --- a/.github/workflows/vtest.yml +++ b/.github/workflows/vtest.yml @@ -87,7 +87,6 @@ jobs: ADDLIB="-Wl,-rpath,/usr/local/lib/ -Wl,-rpath,$HOME/opt/lib/" sudo make install - name: Show HAProxy version - if: ${{ !failure() }} id: show-version run: | echo "::group::Show dynamic libraries." @@ -102,11 +101,9 @@ jobs: haproxy -vv echo "::set-output name=version::$(haproxy -v |awk 'NR==1{print $3}')" - name: Install problem matcher for VTest - if: ${{ !failure() }} # This allows one to more easily see which tests fail. run: echo "::add-matcher::.github/vtest.json" - name: Run VTest for HAProxy ${{ steps.show-version.outputs.version }} - if: ${{ !failure() }} id: vtest run: | # This is required for macOS which does not actually allow to increase -- 2.33.1
