Hello, The attached patch implements a somehow ugly way to cache the VTest binary, basically it gets the commit ID by doing a curl of the master.patch on the github URL.
It allows to save ~8s per matrix row, which is around 160s in total. I know there is a small window where the curl and the git clone won't have the same ID but that will be rebuild anyway for the next build, so that's fine in my opinion. We could probably use the same approach to cache quictls or anything that uses a git repository. Also, I'm wondering if we could also cache the build of HAProxy, you could think that weird, but in fact it will help relaunch the tests when one is failing, without rebuilding the whole thing. Let me know if we can improve the attached patch, otherwise I'll merge it. Regards, -- William Lallemand
>From 34649ae5549a73d0f43530794f47861fb679510e Mon Sep 17 00:00:00 2001 From: William Lallemand <[email protected]> Date: Tue, 8 Mar 2022 14:49:25 +0100 Subject: [PATCH] CI: github: add VTest to the github actions cache Get the latest master commit ID from VTest and use it as a key for the cache. VTest takes around 8s to build per matrix row, we save around 160s of CI with this. --- .github/workflows/vtest.yml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/.github/workflows/vtest.yml b/.github/workflows/vtest.yml index a9e86b6a22..38099093cd 100644 --- a/.github/workflows/vtest.yml +++ b/.github/workflows/vtest.yml @@ -55,6 +55,11 @@ jobs: run: | echo "::set-output name=key::$(echo ${{ matrix.name }} | sha256sum | awk '{print $1}')" + - name: Get VTest master commit ID + id: vtest-id + run: | + echo "::set-output name=key::$(curl -s https://github.com/vtest/VTest/commit/master.patch 2>/dev/null | head -n1 | awk '{print $2}')" + - name: Cache SSL libs if: ${{ matrix.ssl && matrix.ssl != 'stock' && matrix.ssl != 'BORINGSSL=yes' && matrix.ssl != 'QUICTLS=yes' }} id: cache_ssl @@ -70,6 +75,14 @@ jobs: with: path: '~/opt-ot/' key: ot-${{ matrix.CC }}-${{ env.OT_CPP_VERSION }}-${{ contains(matrix.name, 'ASAN') }} + + - name: Cache VTest binary + id: cache_vtest + uses: actions/cache@v2 + with: + path: '~/vtest/' + key: vtest-${{ steps.vtest-id.outputs.key }}-${{ steps.generate-cache-key.outputs.key }} + - name: Install apt dependencies if: ${{ startsWith(matrix.os, 'ubuntu-') }} run: | @@ -86,8 +99,11 @@ jobs: brew install socat brew install lua - name: Install VTest + if: ${{ steps.cache_vtest.outputs.cache-hit != 'true' }} run: | scripts/build-vtest.sh + mkdir ~/vtest/ + cp ../vtest/vtest ~/vtest/ - name: Install SSL ${{ matrix.ssl }} if: ${{ matrix.ssl && matrix.ssl != 'stock' && steps.cache_ssl.outputs.cache-hit != 'true' }} run: env ${{ matrix.ssl }} scripts/build-ssl.sh @@ -134,7 +150,7 @@ jobs: # This is required for macOS which does not actually allow to increase # the '-n' soft limit to the hard limit, thus failing to run. ulimit -n 5000 - make reg-tests VTEST_PROGRAM=../vtest/vtest REGTESTS_TYPES=default,bug,devel + make reg-tests VTEST_PROGRAM=~/vtest/vtest REGTESTS_TYPES=default,bug,devel - name: Show VTest results if: ${{ failure() && steps.vtest.outcome == 'failure' }} run: | -- 2.32.0
