The flt_ot_var_get() function is not used anywhere and is unnecessary in the existing implementation of the OpenTracing filter.
-- Miroslav Zagorac Senior Developer
>From 1faf31cb0ed0cb41e89dc189cee3c753aa1cba55 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac <[email protected]> Date: Tue, 1 Mar 2022 18:39:18 +0100 Subject: [PATCH 04/16] CLEANUP: opentracing: removed unused function flt_ot_var_get() The flt_ot_var_get() function is not used anywhere and is unnecessary in the existing implementation of the OpenTracing filter. --- addons/ot/include/vars.h | 1 - addons/ot/src/vars.c | 48 ---------------------------------------- 2 files changed, 49 deletions(-) diff --git a/addons/ot/include/vars.h b/addons/ot/include/vars.h index da1a04986..c683b6bc6 100644 --- a/addons/ot/include/vars.h +++ b/addons/ot/include/vars.h @@ -33,7 +33,6 @@ void flt_ot_vars_dump(struct stream *s); int flt_ot_var_register(const char *scope, const char *prefix, const char *name, char **err); int flt_ot_var_set(struct stream *s, const char *scope, const char *prefix, const char *name, const char *value, uint opt, char **err); int flt_ot_vars_unset(struct stream *s, const char *scope, const char *prefix, uint opt, char **err); -int flt_ot_var_get(struct stream *s, const char *scope, const char *prefix, const char *name, char **value, uint opt, char **err); struct otc_text_map *flt_ot_vars_get(struct stream *s, const char *scope, const char *prefix, uint opt, char **err); #endif /* _OPENTRACING_VARS_H_ */ diff --git a/addons/ot/src/vars.c b/addons/ot/src/vars.c index 1a8244c46..82b089b82 100644 --- a/addons/ot/src/vars.c +++ b/addons/ot/src/vars.c @@ -379,54 +379,6 @@ int flt_ot_vars_unset(struct stream *s, const char *scope, const char *prefix, u } -/*** - * NAME - * flt_ot_var_get - - * - * ARGUMENTS - * s - - * scope - - * prefix - - * name - - * value - - * opt - - * err - - * - * DESCRIPTION - * - - * - * RETURN VALUE - * - - */ -int flt_ot_var_get(struct stream *s, const char *scope, const char *prefix, const char *name, char **value, uint opt, char **err) -{ - struct sample smp; - char var_name[BUFSIZ], var_value[BUFSIZ]; - int retval; - - FLT_OT_FUNC("%p, \"%s\", \"%s\", \"%s\", %p:%p, %u, %p:%p", s, scope, prefix, name, FLT_OT_DPTR_ARGS(value), opt, FLT_OT_DPTR_ARGS(err)); - - retval = flt_ot_var_name(scope, prefix, name, var_name, sizeof(var_name), err); - if (retval == -1) - FLT_OT_RETURN(retval); - - (void)memset(&smp, 0, sizeof(smp)); - (void)smp_set_owner(&smp, s->be, s->sess, s, opt | SMP_OPT_FINAL); - - if (vars_get_by_name(var_name, retval, &smp, NULL)) { - retval = flt_ot_sample_to_str(&(smp.data), var_value, sizeof(var_value), err); - if (retval != -1) - FLT_OT_DBG(3, "data type %d: '%s' = '%s'", smp.data.type, var_name, var_value); - } else { - FLT_OT_ERR("failed to get variable '%s'", var_name); - - retval = -1; - } - - FLT_OT_RETURN(retval); -} - - /*** * NAME * flt_ot_vars_get - -- 2.30.2
