Ok fair points. On Mon, 11 Apr 2022 at 06:38, Willy Tarreau <w...@1wt.eu> wrote: > > Hi David, > > On Sat, Apr 09, 2022 at 02:44:54PM +0100, David CARLIER wrote: > > Hi, > > > > here a patch proposal to port a subset of the get_tcp_info samples to macOs. > > Thanks, that's quite interesting, but I really don't like the > reordering of the functions to try to group between OSes, for me this > is an indication that the granularity is not sufficient anymore. > > Instead I would suggest to put an explicit set of #if defined().../#endif > around each and every keyword, that will make it easier to spot which ones > are supported by what OS, and this will allow us to extend that as OSes > evolve. > > Please do that in two patches, one to split the ifdefs and a second > one to add MacOS support, this will also make it more obvious what info > is available on this platform. > > Thanks! > Willy
0001-BUILD-SMALL-tcp_sample-clarifying-samples-support-pe.patch
Description: Binary data
