Willy,
[dropping the original PR author from Cc, because my reply is not useful
to them]
On 9/14/22 22:43, Willy Tarreau wrote:
Thanks, but quite honnestly, even this one is not a commit message.
There really is not much to be explained for some obvious typo fixes in
comments (i.e. not even changing the binary). I don't think the commit
message was worse than Ilya's semi-regular typo patches.
I've only put the PR link in the description, because I was unable to
think of literally anything else that might be useful for a typo fix and
I didn't want to leave the description empty (because CONTRIBUTING says
I may not do so).
You get the idea. Regarding the tag, it's fine (and even preferred) to
keep the signed-off-by if you edit the patch, you just add yours below
after a short description between square brackets. Example:
Understood. I've dropped it, because you said in the past that you are
not editing patches containing a s-o-b.
----
I'm not sending another patch or pursuing this patch further, because
that is not a good use of either of our time. I just came across this
unhandled PR in my Inbox and wanted to save you the effort of replying
to the author / fixing the message yourself. Seeing that you took the
effort of writing this long reply, I probably should've just ignored the
patch entirely, because it ultimately wasted time for everyone involved.
Best regards
Tim Düsterhus
