Le 9/21/22 à 11:42, Wright Loz a écrit :
Classification: UK OFFICIAL
Hi,
Reference Github issue 1812 ( https://github.com/haproxy/haproxy/issues/1812
<https://github.com/haproxy/haproxy/issues/1812> ) relating to unclean shutdown
of “smtpchk” health checking, I attach a patch which implements an SMTP QUIT
(and then a wait for successful confirmation) prior to closing the TCP
connection on each SMTP service check.
Hopefully relatively straightforward and obviously happy to discuss!
It seems to be ok at first glance.
However, I must fix the regex to properly match the EHLO reply first. It is a
multi-line reply and, for now, the regex is only matching on the first line. I
will fix it before merging your patch.
In addition and if it is ok for you, I will amend you patch to add information
about backports and to update reg-tests accordingly
(reg-tests/checks/4be_1srv_smtpchk_httpchk_layer47errors.vtc and
reg-tests/checks/smtp-check.vtc)
Thanks !
--
Christopher Faulet
