On Fri, Jan 26, 2024 at 09:22:58PM +0100, ???? ??????? wrote: > ??, 26 ???. 2024 ?. ? 20:01, Willy Tarreau <w...@1wt.eu>: > > > On Fri, Jan 26, 2024 at 05:30:31PM +0100, Willy Tarreau wrote: > > > On Wed, Jan 24, 2024 at 02:26:13PM +0100, Ilya Shipitsin wrote: > > > > it is very fast check, should not affect developer velocity much > > > > > > OK now pushed, thank you Ilya! > > > > Ilya, I reverted the last one (automatic check on push) for now, because > > it's making all pushes fail for reasons that neither the patch's author > > nor the committer can validate before pushing, which is extremly > > frustrating and turning the CI into just noise since it's always red > > now. > > > > >From one hand, validation is not any different than other "pre checkin" > validation, i.e. developer can push to his own fork (it could be automatic > if pull requests were valid way of contribution).
Yes but that's triple work: push to temporary branch, wait for checks to pass while doing nothing, then push to master, then delete temporary branch. And it does not change the fact that it's only the committer that can do that, not the author, which is a real pain since it requires to cancel and rework stuff at the last point in the chain, after everything was already applied and tests ran fine. > from the other hand, we can get back to cron, it will accumulate some > "spell checking debt", but we live with that for years, np Yes for now I think it remains easier this way. But we can continue to explore alternatives. thanks! Willy
