Hi Miroslav, On Tue, Jan 30, 2024 at 03:42:20AM +0100, Miroslav Zagorac wrote: > Hello all, > > In several places in the source, there was the same block of code that was > used to deinitialize the log buffer. There were even two functions that > did this, but they were called only from the code that is in the same > source file (free_tcpcheck_fmt() in src/tcpcheck.c and free_logformat_list() > in src/proxy.c - they were both static functions). > > The function free_logformat_list() was moved from the file src/proxy.c to > src/log.c, and a check of the list before freeing the memory was added to > that function.
Wow, nice catch, great job, you removed 10 list walks on cleanup paths! 9 files changed, 43 insertions(+), 110 deletions(-) And regarding the binary: $ size haproxy-master haproxy-miroslav text data bss dec hex filename 8160770 592116 2666204 11419090 ae3dd2 haproxy-master 8160592 592116 2666204 11418912 ae3d20 haproxy-miroslav I love such patches :-) Thank you! Willy