Hi Nicolas, On Tue, Aug 27, 2024 at 10:18:51PM +0200, Nicolas CARPi wrote: > Found these two typos while browsing the code :) (...) > Found this typo in macro name :)
Thank you, both patches applied. > BTW, in mqtt.c mqtt_read_varint(), "off" is initialized to 0, but > initialized again in the for loop, which results in a dead assignment. > > I believe this is done on purpose, as some sort of defensive > programming, so I didn't touch it, but wanted to bring attention to it, > in case it is not something wanted. Indeed it's not the prettiest but not a problem either. Sometimes this can happen as the result of removing a check and an error path for example. Let's leave it as is, it has no effect anyway :-) Thank you! Willy
