On 22. 04. 2025. 15:54, Christopher Faulet wrote:
> Le 18/04/2025 à 1:38 PM, Miroslav Zagorac a écrit :
>> Hello all,
>>
>> after processing the agent hello frame, the max-frame-size parameter for the
>> agent should be set; otherwise HAProxy can send frames longer than the one
>> that the agent will be able to process - which can lead to the crash of the
>> agent program.
>>
>> This should be backported to version 3.1.
>>
> 
> Thanks Miroslav ! Indeed there is an issue. However your fix is not the right 
> one. The agent configuration must not be changed this way. In fact, it must 
> not 
> be changed at all. It represents the configuration settings. The 
> max-frame-size 
> value that must be used is negotiated for a connection. Two connections to 
> the 
> same agent may have different value. It is unusual but possible.
> 
> The right fix is to check the frame size before sending it to the agent. 
> DISCONNECT and NOTIFY frames are concerned. You can find the patch in 
> attachement.
> 
> 

Hello C,

great, I tried it and it works as expected.  Thank you.


-- 
Miroslav Zagorac
Senior Developer


Reply via email to