Hello Ilya, Could you just fix the following part:
> the unit-test ones lack the "show unit-tests results" that we have in > vtest.yml, it would be better to have it to > display what's going on upon failure. And I'll take them, Thanks On Mon, May 12, 2025 at 10:21:40AM +0200, Илья Шипицин wrote: > Subject: Re: [PATCH 01/10] CI: musl: enable unit tests > all patches were rejected ? > > чт, 24 апр. 2025 г. в 14:56, William Lallemand <wlallem...@haproxy.com>: > > > Hello Ilia, > > > > On Wed, Apr 23, 2025 at 04:44:03PM +0200, Илья Шипицин wrote: > > > personally, I do not think we'll benefit much from "templating" > > workflows. > > > > > > > Only vtest.yml with matrix.py which basically does this templating does > > not lack anything. But if you take a look at the > > other .yml files it lacks a lot of things because we don't bother spending > > time copying the same new things again and > > again in the other 20 .yml files. I think we could really improve that in > > the future. > > > > > what would be really interesting is some kind of reporting based, for > > > example on JUnit xml files (like this Unit test reports | GitLab Docs > > > <https://docs.gitlab.com/ci/testing/unit_test_reports/> ) > > > that way you'll be able to track tests from execution to execution, which > > > one slow down, which one is flaky and so on. > > > > > > it is a pity that you cannot build reports from GHA > > > > > > > Honestly no idea, We probably won't have time to read them, we only > > checking things when there is a failed status on the > > CI. > > > > > > > ср, 23 апр. 2025 г. в 10:40, William Lallemand <wlallem...@haproxy.com>: > > > > > > > On Thu, Apr 17, 2025 at 10:56:12PM +0200, Ilia Shipitsin wrote: > > > > > Subject: [PATCH 01/10] CI: musl: enable unit tests > > > > > Run the new make unit-tests on the CI. > > > > > --- > > > > > .github/workflows/musl.yml | 6 +++++- > > > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/.github/workflows/musl.yml b/.github/workflows/musl.yml > > > > > index a54414fab..b4d91e45a 100644 > > > > > --- a/.github/workflows/musl.yml > > > > > +++ b/.github/workflows/musl.yml > > > > > @@ -26,7 +26,7 @@ jobs: > > > > > - name: Install VTest > > > > > run: scripts/build-vtest.sh > > > > > - name: Build > > > > > - run: make -j$(nproc) TARGET=linux-musl ARCH_FLAGS='-ggdb3' > > > > CC=cc V=1 USE_LUA=1 LUA_INC=/usr/include/lua5.3 LUA_LIB=/usr/lib/lua5.3 > > > > USE_OPENSSL=1 USE_PCRE2=1 USE_PCRE2_JIT=1 USE_PROMEX=1 > > > > > + run: make -j$(nproc) TARGET=linux-musl > > > > DEBUG="-DDEBUG_POOL_INTEGRITY -DDEBUG_UNIT" ARCH_FLAGS='-ggdb3' CC=cc > > V=1 > > > > USE_LUA=1 LUA_INC=/usr/include/lua5.3 LUA_LIB=/usr/lib/lua5.3 > > USE_OPENSSL=1 > > > > USE_PCRE2=1 USE_PCRE2_JIT=1 USE_PROMEX=1 > > > > > - name: Show version > > > > > run: ./haproxy -vv > > > > > - name: Show linked libraries > > > > > @@ -37,6 +37,10 @@ jobs: > > > > > - name: Run VTest > > > > > id: vtest > > > > > run: make reg-tests VTEST_PROGRAM=../vtest/vtest > > > > REGTESTS_TYPES=default,bug,devel > > > > > + - name: Run Unit tests > > > > > + id: unittests > > > > > + run: | > > > > > + make unit-tests > > > > > - name: Show coredumps > > > > > if: ${{ failure() && steps.vtest.outcome == 'failure' }} > > > > > run: | > > > > > > > > Hello Ilia, > > > > > > > > the unit-test ones lack the "show unit-tests results" that we have in > > > > vtest.yml, it would be better to have it to > > > > display what's going on upon failure. > > > > > > > > I wonder if we can't just inherit most of the steps instead of copying > > the > > > > same yml part in every part, it would be less > > > > difficult to maintain. > > > > > > > > Regards, > > > > > > > > -- > > > > William Lallemand > > > > > > > > -- > > William Lallemand > > -- William Lallemand
