Thank you William for all your help. Appreciate it. Regards, Mariam.
From: William Lallemand <wlallem...@haproxy.com> Date: Tuesday, July 1, 2025 at 4:57 AM To: Mariam John <john.mariam....@gmail.com> Cc: haproxy@formilux.org <haproxy@formilux.org>, MARIAM JOHN <mari...@us.ibm.com> Subject: [EXTERNAL] Re: [PATCH 0/1] Add new helper function smp_client_hello_parse() On Wed, Apr 30, 2025 at 12:11:13PM -0500, Mariam John wrote: > Subject: [PATCH 0/1] Add new helper function smp_client_hello_parse() > Hello William, > > This is in continuation of the earlier patches submitted to add 4 new > sample fetches > to extract cipher, supported groups, key shares and signature algorithms from > client hello > message. In the previous patches we added the 4 new sample fetches and a test > for it. > > In this patch we add a new helper function `smp_client_hello_parse` to > extract information > presented in a TLS client hello handshake message that is common in the other > sample fetches > in payload.c. We have modified these 7 sample fetches to use this new helper > function. > > David Kelsey here at IBM also contributed to this last patch and helped me > fix all the > formatting issues, so hopefully that will make it easy for you to review. > Thank you David. > > Thank you William for helping us move this forward. Appreciate all your > feedback. > > Regards, > Mariam. > > Thank you Mariam, seems good to me, I just merged the patch into master! -- William Lallemand