Hello William. Thanks for your work on this. And merging also. There seem to be conventions I haven't paid proper attention to due to numerous changes previously. Now that I'm fully aware, I'll make sure to address them in upcoming patches.
Thanks, On Wed, Jan 21, 2026 at 1:31 AM William Lallemand <[email protected]> wrote: > Hello Hyeonggeun, > > I merged this first one in master with a few changes explained below. > > On Tue, Jan 20, 2026 at 10:27:40PM +0900, Hyeonggeun Oh wrote: > > Subject: [PATCH 1/3] REORG: cfgparse: move peers parsing to > cfgparse-peers.c > > I don't know why you have an extra "---" at the beginning at your patch, it > ignores the commit message once I'm applying the patch, I had to remove > them > manually. > > > --- > > > > This patch move the peers section parsing code from src/cfgparse.c to a > dedicated src/cfgparse-peers.c file. This seperation improves code > organization and prepares for further refactoring of the "peers" keyword > registration system. > > > > No functional changes in this patch - the code is moved as-is with only > the necessary adjustments for compliation (adding SPDX header and updating > Makefile for build). > > > > This is the first patch in a series to address issue #3221, which > reports that "peers" section keywords are not displayed with -dKall. > > Please wrap you commit messages to 80 columns, the lines are a bit too > long this way. > > > --- > > Makefile | 2 +- > > src/cfgparse-peers.c | 607 +++++++++++++++++++++++++++++++++++++++++++ > > src/cfgparse.c | 576 +--------------------------------------- > > 3 files changed, 609 insertions(+), 576 deletions(-) > > create mode 100644 src/cfgparse-peers.c > > > > diff --git a/Makefile b/Makefile > > index c4d1d0b72..a9a801bb7 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -964,7 +964,7 @@ endif > > OBJS += src/mux_h2.o src/mux_h1.o src/mux_fcgi.o src/log.o \ > > src/server.o src/stream.o src/tcpcheck.o src/http_ana.o > \ > > src/stick_table.o src/tools.o src/mux_spop.o src/sample.o \ > > - src/activity.o src/cfgparse.o src/peers.o src/cli.o \ > > + src/activity.o src/cfgparse.o src/cfgparse-peers.o src/peers.o > src/cli.o \ > > src/backend.o src/connection.o src/resolvers.o src/proxy.o \ > > src/cache.o src/stconn.o src/http_htx.o src/debug.o \ > > src/check.o src/stats-html.o src/haproxy.o src/listener.o \ > > I moved the file at the end of the list for now. > > > diff --git a/src/cfgparse-peers.c b/src/cfgparse-peers.c > > new file mode 100644 > > index 000000000..b7183229e > > --- /dev/null > > +++ b/src/cfgparse-peers.c > > @@ -0,0 +1,607 @@ > > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > > + > > +/* > > + * Configuration parser for peers section > > + * > > + * Copyright 2000-2011 Willy Tarreau <[email protected]> > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License > > + * as published by the Free Software Foundation; either version > > + * 2 of the License, or (at your option) any later version. > > + * > > + */ > > No need for the GPL abstract and copyright once you have the SPDX header. > > -- > William Lallemand > >
