we are eliminating cppcheck findings one by one. maybe at some time cppcheck will be (or will not) another quality gate
ср, 13 мая 2026 г. в 17:02, Willy Tarreau <[email protected]>: > Hi Ilya, > > On Tue, May 12, 2026 at 12:14:03PM +0200, Ilia Shipitsin wrote: > > addons/51degrees/51d.c:638:1: error: Unmatched '}'. Configuration: ''. > [syntaxError] > > --- > > addons/51degrees/51d.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/addons/51degrees/51d.c b/addons/51degrees/51d.c > > index a23b468d6..a00da8d48 100644 > > --- a/addons/51degrees/51d.c > > +++ b/addons/51degrees/51d.c > > @@ -550,6 +550,8 @@ static void _51d_process_match(const struct arg > *args, struct sample *smp) > > char valuesBuffer[1024]; > > #endif > > > > +#if defined(FIFTYONEDEGREES_H_PATTERN_INCLUDED) || > defined(FIFTYONEDEGREES_H_TRIE_INCLUDED) || > defined(FIFTYONE_DEGREES_HASH_INCLUDED) > > + > > char no_data[] = "NoData"; /* response when no data could be > found */ > > struct buffer *temp = get_trash_chunk(); > > int i = 0, found; > > @@ -636,6 +638,7 @@ static void _51d_process_match(const struct arg > *args, struct sample *smp) > > smp->data.u.str.area = temp->area; > > smp->data.u.str.data = temp->data; > > } > > +#endif > > Good catch. Initially I thought your ifdef was wrong, but no, it's the > original. I don't think I had ever seen so ugly ifdefery that presents > or hides parts of consecutive function declarations and variables with > different ifdefs, to the point where depending on the combinations you > can even have the beginning of a function and no end. I wan't say I love > the result with your fix, but at least it should address this. > > Merged, thank you! > willy >
