пт, 31 июл. 2026 г. в 15:49, William Lallemand <[email protected]>:
> On Fri, Jul 31, 2026 at 03:37:07PM +0200, Илья Шипицин wrote: > > Subject: Re: [PATCH] CI: migrate vtest workflows to local JS action and > centralize test diagnostics > > пт, 31 июл. 2026 г. в 15:08, William Lallemand <[email protected]>: > > > > > On Thu, Jul 30, 2026 at 05:40:54PM +0200, Willy Tarreau wrote: > > > > Subject: Re: [PATCH] CI: migrate vtest workflows to local JS action > and > > > centralize test diagnostics > > > > Hi Ilya, > > > > > > > > On Wed, Jul 01, 2026 at 10:44:02PM +0200, Ilia Shipitsin wrote: > > > > > Convert the vtest setup action to a Node 24 JavaScript action. > > > > > Rename the action path from setup-vtest to vtest and update > workflow > > > references. > > > > > move VTest execution into the action so Run VTest steps call the > > > action directly > > > > > move VTest failure logs and coredump reporting into the action post > > > step > > > > > simplify workflow jobs by removing duplicated Show VTest results > and > > > Show coredumps steps > > > > > fix container path issues by using a workspace-relative vtest > binary > > > during reg-tests > > > > > > > > Care to explain the purpose ? I'm having a hard time decoding what is > > > > written above (missing punctuation and case makes it quite hard), and > > > > I don't understand if it tries to resolve an issue, improve > something, > > > > clean something up, simplify something, perform some needed code > > > > maintenance etc. It would really help reviews to have more info, > because > > > > I think that for most readers the question remains "I'm not sure > whether > > > > I'm supposed to be authoritative on that", and that's left for > someone > > > > else to deal with :-( > > > > > > > > Thanks! > > > > Willy > > > > > > > > > > I'm not so sure about that, does it provide any advantages after being > > > converted ? Because to me it seems just more painful to read and > maintain. > > > > > > > advantage is that you do not copy "Show VTest results" and "Show core > > dumps" to every job, they are now > > part of javascript action and assigned on "post" event > > > > So it's not possible to achieve the same in yaml? > from what I found it is supported by javascript actions and not supported by composite (i.e. yaml) actions > > > -- > William Lallemand >
