Commit 7b01a8dbdd("MINOR: global: define diagnostic mode of execution")
in 2.4-dev15 introduced diagnostic mode for config warnings.

It was initially designed to be ignored by "zero-warning" mode
(-dW) and documented accordingly.

Since commit ced4148401 ("BUG/MINOR: diag: always show the version
before dumping a diag warning") in 3.0-dev3 this changed, and
zero-warning mode combined with diagnostic messages stop haproxy from
starting. This appears to be a unintended consequence in ced4148401.

I suggest we respect "zero-warning" mode, which is an opt-in choice an
administrator consciously makes and stop haproxy from starting when
diagnostic messages are emitted in zero-warning mode.

This means _maintaining_ the behavior we had for the past 5 stable
branches and updating the documentation to reflect that.

Should be backported where ced4148401 was committed; until 3.0 as-is; for
2.8: replace /Since 3.0/Since 2.8.6/
---
 doc/management.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/management.txt b/doc/management.txt
index 6bfeec6ca0..863ed3eb8f 100644
--- a/doc/management.txt
+++ b/doc/management.txt
@@ -237,8 +237,8 @@ list of options is :
     key. Please also see the CLI's "set anon" command.
 
   -dD : enable diagnostic mode. This mode will output extra warnings about
-    suspicious configuration statements. This will never prevent startup even 
in
-    "zero-warning" mode nor change the exit status code.
+    suspicious configuration statements. Since 3.0 this will prevent startup
+    in "zero-warning" mode.
 
   -dF : disable data fast-forward. It is a mechanism to optimize the data
     forwarding by passing data directly from a side to the other one without
-- 
2.17.1



Reply via email to