On Wed, Oct 28, 2026 at 08:42:31AM +0100, Willy Tarreau wrote: > Hi, > > On Tue, Oct 27, 2026 at 04:09:48AM +0000, Martin Mirchev wrote: > > Hi, > > > > Here are two small config parsing fixes against current master (3e758361c). > > Each one has a reg-test under reg-tests/startup/. The patches are attached > > (git format-patch). > (...) > > Thank you! > > Just one thing, I prefer that we don't add VTCs targetting a specific > bug, because once the bug is fixed, it has no reason for coming back in > the exact same form again, and the test clobbers reg tests for no added > value. However VTCs are convenient for local testing and backports. Thus > I think that in the future it could be convenient to either attach the > vtc separately, or more simply to add it as a separate patch. We do have > a REGTEST_TYPE=bug category already for this, though I am not convinced > it has ever brought any value to be honest (aside starting with something > at the very beginning). Where merged reg tests matter is with new features > as well as entire bug classes when it's identified that a recurring bug > keeps appearing (e.g. failing to check release memory on clean exit, > ignoring an extra arg on a keyword, etc). > > As such, I'll review your patch series and will merge them without the > vtc, so just don't be surprised ;-)
And now all merged, thanks! willy
