On 11/7/26 20:44, [email protected] wrote:
> diff --git a/src/quic_rx.c b/src/quic_rx.c
> index 74e3f79a5..fb54d7867 100644
> --- a/src/quic_rx.c
> +++ b/src/quic_rx.c
> @@ -2074,6 +2074,12 @@ static int quic_rx_pkt_parse(struct quic_conn *qc, 
> struct quic_rx_packet *pkt,
>                       goto drop_silent;
>               }
>  
> +             if (!l && (!pkt->version || !pkt->version->num)) {
> +                     TRACE_PROTO("RX unsupported version or VN packet on 
> backend",
> +                                 QUIC_EV_CONN_LPKT, NULL, NULL, NULL, 
> pkt->version);
> +                     goto drop;
> +             }

I am sorry but I cannot merge this one as-is, even if it is correct.

I agree that a Version Negotiation packet is a long header packet with a
4-byte null version field (0x00000000) but one should stop
writing/testing this like that : !pkt->version->num. I would prefer :

      !l && (!pkt->version || pkt->version == &quic_version_VN_reserved)

That said, Version Negotiation packet type is not supported because one
does not support the version negotiation feature on backend side. This
could be written as follows:

       (!l && pkt->version != qc->original_version)

with qc->original_version initialized to <quic_version_1> for backends.

Would you like me to fix this issue, or would you prefer to rewrite your
patch?

Furthermore, no need to provide a reg test for this bug. We try to use
as few as possible python scripts. Also, this should be classified as
MINOR for backends.


Reply via email to