Hi Alex,
I'll retrofit these changes to trunk later. 2008-09-11 13:13 UTC+0200 Viktor Szakats (harbour.01 syenar hu) * contrib/gtwvg/wvgutils.c ! Fixed last MSVC -W4 warnings. ; NOTE: Only these contribs have remaining -W4 warnings: hbbmcdx, hbbtree, hbct (in screen*.c). Plus core.I am grateful for the amount of hard work you are doing, but I wonder if you are not making a stick for your back. Doesn't it make sense to only apply bug fixes to the 1.0 branch? You may even be introducing some problems to that stable branch with such wide ranging changes? What is your goal with the 1.0 branch?
I see your concern, but most of these "fixes" are actually pretty benign changes, if there is (rarely) an option for a more deep fix and a light one, I choose the latter. Most of these warnings are actually pinpointing existing implicit casts, which I'm usually just making explicit. It's very rare that there is a real problem behind (but some got uncovered while scanning the code). But maybe you're right, nothing beats testing and testing this amount of code is really difficult, especially on such - probably unused - contribs as hbwhat, where most of the heavy lifting was done. It would also help if someone could review these changes, they are not complicated ones, but a mistake can slip in anytime. 1.0.1 goals are pretty much met now. Some known problems, and some others which were found and fixed after the release. Some changes also slipped in, which would be better go to 1.1, but it's simply too time consuming to keep testing two separate branches, so they'll also go to 1.0.1, most of them is guarded with HB_LEGACY_LEVEL. I think we can just start platform build testing 1.0 right now, so that we can make a release ASAP.
On a separate subject, the compiled contrib libs are dropped in the harbour libs dir, I would like them to go in a separate dir, because I keep them separately when I install them. What is your opinion?
Great that we have two different make systems ;), because they are different cases. In GNU make, you may do a build session with HB_CONTRIBLIBS set to some false targets, HB_LIB_INSTALL to your core lib dir, then do another build session where you reset HB_CONTRIBLIBS to be empty, and set HB_LIB_INSTALL to your contrib destination. In non-GNU make, core and contrib are different sessions anyway, so all you need to do is change HB_LIB_INSTALL after calling /make_*.bat and before calling contrib/make_*_all.bat. I didn't test these, but this is the theory. Brgds, Viktor _______________________________________________ Harbour mailing list [email protected] http://lists.harbour-project.org/mailman/listinfo/harbour
