> I didn't know. I thought it's some garbage from old unused code
> (macro which could be redefined for different format of string
> representation) and I removed it making a fix.
>
>> (or removed from all other places in VM and also remove the
>> definition of this macro from hbapi.h)
>
> I planed to make it. Anyhow if it was used intentionally and I know
> this intention ;-) then I can keep it and restore inside hb_errInternal().
> Anyhow I cannot say that I fully understand the logic how it should
> be used, i.e. why we have in hvm.c:
>      hb_conOutErr( "Cancelled at: ", 0 );
>      hb_snprintf( buffer + l, sizeof( buffer ) - l, " (%hu)%s%s", uiLine, 
> *file ? HB_I_(" in ") : "", file );
>      hb_conOutErr( buffer, 0 );
> "Cancelled at: " is not translateable string and " in " is?

No such provisions were made, it was added very long ago before
I could know anything about final translation method we would use,
so the only intent was to mark strings as such to know where to
look for when implementing it properly. "Cancelled at" just missed
the mark in the meantime, and should be added.

If we go the translation way, we will have to avoid any such text assemblies
like above and use masks which form a meaningful sentence:
"Cancelled at: %1$s" and "Cancelled at: %1$s in %2$s" in above code.

Brgds,
Viktor
_______________________________________________
Harbour mailing list
[email protected]
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to